Skip to content

Replace serde_yaml with yaml_serde - #888

Merged
adwk67 merged 5 commits into
mainfrom
chore/yaml-serde
Oct 16, 2026
Merged

adwk67 merged 5 commits into
mainfrom
chore/yaml-serde

Conversation

@adwk67

@adwk67 adwk67 commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Description

Part of stackabletech/issues#898.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67 adwk67 self-assigned this Oct 15, 2026
@adwk67 adwk67 moved this to Development: Waiting for Review in Stackable Engineering Oct 15, 2026
@adwk67

adwk67 commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

Pending tests.....

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 15, 2026
Comment thread CHANGELOG.md Outdated
@adwk67

adwk67 commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

Tests:

--- PASS: kuttl (371.28s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_druid-37.0.0_zookeeper-3.9.6_hadoop-3.5.0_openshift-false (371.27s)
PASS
--- PASS: kuttl (234.17s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/overrides_druid-latest-37.0.0_zookeeper-latest-3.9.6_hadoop-latest-3.5.0_openshift-false (234.16s)
PASS

@adwk67
adwk67 requested a review from NickLarsenNZ October 15, 2026 11:42

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwk67
adwk67 added this pull request to the merge queue Oct 16, 2026
Merged via the queue into main with commit 7f06bf3 Oct 16, 2026
13 checks passed
@adwk67
adwk67 deleted the chore/yaml-serde branch October 16, 2026 09:29
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Oct 16, 2026
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants