Repository navigation
Honor optimization=False when generating patches - #233
Merged
stefankoegl merged 1 commit intoOct 19, 2026
Merged
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsonPatch.from_diff(..., optimization=False)currently still producesmoveoperations. This prevents using generated patches with consumers that support onlyadd,remove, andreplace, as reported in #172.Pass the existing option to the diff builder and disable matching added and removed values when it is false. The default behavior stays enabled. The option is documented on
from_diff.Fixes #172.
Validation: four reproductions failed before the fix. All 210 unit tests and 20 property tests pass after it, including a new generated-document round-trip test without move optimization. Coverage includes object renames, array reordering, nested values, escaped pointer keys, and source immutability. The CI fatal-error Flake8 selection and
git diff --checkpass.AI-assisted implementation and tests.