Repository navigation
Preserve one-shot operation iterators during patch validation - #234
Open
Apeksha9389 wants to merge 1 commit into
Open
Apeksha9389 wants to merge 1 commit into
Apeksha9389 wants to merge 1 commit into
Conversation
|
coverage: 100.0%. remained the same — Apeksha9389:fix/preserve-operation-iterators into stefankoegl:master |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsonPatch(iter(operations)).apply(document)currently applies no operations: construction validates and exhausts the iterator before application can read it. Empty iterators also produce a truthy patch, and serializing an iterator-backed patch fails.Materialize one-shot iterators before validation. Existing list and tuple inputs retain their container behavior. Regression tests cover list iterators and generators, repeated application and serialization, empty iterators, invalid operations, and preservation of the original list container.
Validation on Python 3.12.14: 217 unit tests and 20 Hypothesis property tests pass. The iterator and empty-iterator regressions produce three failures without the fix. Ruff syntax/undefined-name checks and
git diff --checkpass. Windows and the other Python versions were not run locally.AI disclosure: This patch, tests, and description were prepared with OpenAI Codex assistance. The reported checks were executed locally.