Repository navigation
Conversation
roychying
added this pull request to stack #880
October 16, 2026 18:43
roychying
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 16, 2026 18:43
roychying
force-pushed
the
chenghan.ying/github-validator-e2e
branch
from
October 16, 2026 18:57
3c6d8f3 to
e7868a2
Compare
roychying
force-pushed
the
chenghan.ying/github-validator-e2e
branch
from
October 16, 2026 18:58
e7868a2 to
ecf3329
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The GitHub validator's unit tests run against a fake. Only the real API shows whether its GraphQL query and its reading of the response are right: field names,
isRequiredfor a given pull request, and errors for a missing pull request. This follows the pattern of the GitHub merger's live tests.What?
TestGitHubLandE2E:e2e-github-queuenow setsvalidator: {type: github}. Every full-stack land (a single pull request and a stack) passes through the validator against the test repository before it is batched.test/integration/submitqueue/extension/validator/github, which opens throwaway pull requests viagithubtestrepoand checks that:validator-integration-testjob, added torequired-checks.SQ_TEST_REPO_TOKENandSQ_GITHUB_TEST_REPO; it fails rather than skips when the repository opted in but the secret is missing.make integration-test-submitqueue-validator.doc/howto/TESTING.mdlists the third live suite.The test repository requires no reviews or checks, because the tests merge directly. So the live suites cover the passing path and real-API behaviour. The review and check rules are covered by the parent PR's unit tests.
If
SQ_TEST_REPO_TOKENis a fine-grained token and the test repository is private, it may need read access to checks and commit statuses. Without it, GitHub may refuse the check-related fields, the validator would fail, and the e2e land tests would end inerror.Test Plan
bazel test //test/integration/submitqueue/extension/validator/...).make lint check-gazelle check-mocks check-tidypass.Run against a real test repository (see
doc/howto/TESTING.md):Issue