Repository navigation
Conversation
manjari25
added this pull request to stack #883
October 16, 2026 20:28
manjari25
marked this pull request as ready for review
October 16, 2026 22:00
manjari25
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 16, 2026 22:00
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The Tango-backed conflict analyzer receives, from Tango, each affected target as a label with a distance. It compares batches by 64-bit target IDs, so those pairs need a deterministic conversion into the sorted, duplicate-free targets that a
TargetSignaturestores. This PR adds that conversion.What?
Everything is added under
submitqueue/extension/conflict/tango:LabelDistance, the pair an adapter returns for each affected target: the label exactly as Tango reported it, and its distance from the nearest directly changed source.targetID, which hashes a label to its 64-bit ID: the first 8 bytes of the SHA-256 of the label, read big-endian.toSignatureTargets, which turns label and distance pairs into:Test Plan
./tool/bazel test //submitqueue/extension/conflict/tango/...make check-gazellemake check-mocksmake lintCI
Issue