Repository navigation
Conversation
🦋 Changeset detectedLatest commit: f46cbc7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
dreyfus92
left a comment
There was a problem hiding this comment.
thanks for this! @btea 😄
one blocker, the fix lives in @clack/core but the changeset only bumps @clack/prompts. since prompts pins an exact core version, core needs a patch bump too or the fix never ships. could we add "@clack/core": patch?
small suggestion, could we move the disabled check into the find predicate? right now with a disabled delete and an enabled deploy, pressing d selects nothing since find stops at the disabled one first. with !disabled inside the predicate it'd pick deploy.
separately, the renderer doesn't style disabled options yet, so they look selectable and the initial cursor can land on one. fine as a follow up imo.
cc @43081j
|
Thank you for your review and suggestions. Adjustments have been made. |
|
is #622 this same change plus more? i see it isn't a stacked commit, both branches implement the same thing but that one does more? i wonder if we should just do both in one. this isn't a "fix" because we never had "disabled options" in this prompt, you're introducing that feature. i'd just do both changes in one since it doesn't make much sense to add support for disabled and not render it |
What does this PR do?
Ignore key presses that match disabled options so they cannot be submitted through selectKey.
Type of change
Checklist
pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure