Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 7d14250 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
6 of 12 tasks
43081j
reviewed
Oct 19, 2026
| }); | ||
| this.cursor = Math.max(keys.indexOf(opts.initialValue), 0); | ||
| const cursor = Math.max(keys.indexOf(opts.initialValue), 0); | ||
| this.cursor = this.options[cursor]?.disabled ? findCursor<T>(cursor, 1, this.options) : cursor; |
Collaborator
There was a problem hiding this comment.
im not sure this is right. we do this in selects because if you press up/down, we want to hop over the disabled options.
but in select-key, there's no concept of directional movement through options. so if you set the initial value to a disabled one, we should probably just ignore it.
5 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
refer to #620 (review)
Type of change
Checklist
pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure