Repository navigation
Conversation
`graphileWorkerIntegration({ monitorCronJobs: true })` sends check-ins for
the jobs the graphile-worker crontab schedules, using the crontab item
identifier as monitor slug. `excludeCronJobs` skips items.
Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
size-limit report 📦
|
Bun's `bun run` doesn't inject the channels, and the CJS test of the ESM-only graphile-worker 0.18 isn't hooked on Node 20 or Deno. Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a series adding automatic Crons monitoring for the most-used job schedulers in each SDK. Check-ins for a monitor that doesn't exist yet are dropped, so today each monitor has to be created by hand with its schedule copied from the code. Sending the job's schedule as the monitor config lets Sentry create the monitor and keep it in sync.
Description
Adds
graphileWorkerIntegrationfor graphile-worker 0.16 to 0.18. WithmonitorCronJobs: true, each job the crontab schedules sends anin_progresscheck-in when it starts andokorerrorwhen it completes. Errors are also captured. The job runs and fails exactly as before: the integration only listens to the runner'sjob:startandjob:completeevents, which it gets from the instrumentedrunCron.The slug is the crontab item identifier (
?id=, or else the task identifier), which graphile-worker already requires to be unique. A cron job only carries its task, payload and scheduled time, so the integration matches it to the item by task and schedule, then by payload; jobs it can't match to exactly one item, and jobs not scheduled by the crontab, are not monitored. Jobs are only monitored by a process that runs the crontab, whichrun()does by default.This PR sends check-ins without a monitor config. The stacked follow-up sends the crontab schedule.
Testing
Unit tests, and a node integration test against Postgres with graphile-worker 0.16 and 0.18 (ESM and CJS) that uses
?fillbackfill to run the jobs right away.