Repository navigation
Remove enableImperativeEvents_DEPRECATED feature flag - #59183
Closed
rubennorte wants to merge 1 commit into
Closed
rubennorte wants to merge 1 commit into
rubennorte wants to merge 1 commit into
Conversation
Summary: The JS-only `enableImperativeEvents_DEPRECATED` flag was kept so JS bundles delivered to older native builds, where the common `enableImperativeEvents` flag was unavailable, could still enable the feature. Those builds are gone, so remove the deprecated flag and gate `ReactNativeElement` and `ReadOnlyText` solely on the common flag. Changelog: [Internal] Differential Revision: D126047688
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126047688. |
Collaborator
|
This pull request was successfully merged by @rubennorte in 02aef9b When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in 02aef9b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The JS-only
enableImperativeEvents_DEPRECATEDflag was kept so JS bundles delivered to older native builds, where the commonenableImperativeEventsflag was unavailable, could still enable the feature. Those builds are gone, so remove the deprecated flag and gateReactNativeElementandReadOnlyTextsolely on the common flag.Changelog: [Internal]
Differential Revision: D126047688