Skip to content

Remove enableImperativeEvents_DEPRECATED feature flag #59183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rubennorte wants to merge 1 commit into from
Closed

Remove enableImperativeEvents_DEPRECATED feature flag #59183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1116,16 +1116,6 @@ const definitions: FeatureFlagDefinitions = {
},
ossReleaseStage: 'none',
},
enableImperativeEvents_DEPRECATED: {
defaultValue: false,
metadata: {
description:
'Deprecated in favor of the common flag with the same name, which is the one that can be configured by OSS release stage. This is only kept so JS bundles delivered to older native builds, where the common flag is unavailable, can still enable the feature.',
expectedReleaseValue: true,
purpose: 'release',
},
ossReleaseStage: 'none',
},
enableNativeEventTargetEventDispatching: {
defaultValue: true,
metadata: {
Expand Down
8 changes: 1 addition & 7 deletions packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @generated SignedSource<<4eb26b4190d023d26a50f54b6e3ea5eb>>
* @generated SignedSource<<f36d78d946c018d3dd3fc30f6071ee76>>
* @flow strict
* @noformat
*/
Expand Down Expand Up @@ -34,7 +34,6 @@ export type ReactNativeFeatureFlagsJsOnly = Readonly<{
animatedKeepListenersOnDetach: Getter<boolean>,
animatedShouldSyncValueBeforeStartCallback: Getter<boolean>,
deferFlatListFocusChangeRenderUpdate: Getter<boolean>,
enableImperativeEvents_DEPRECATED: Getter<boolean>,
enableNativeEventTargetEventDispatching: Getter<boolean>,
externalElementInspectionEnabled: Getter<boolean>,
fixCrossOrientationNestedListViewability: Getter<boolean>,
Expand Down Expand Up @@ -176,11 +175,6 @@ export const animatedShouldSyncValueBeforeStartCallback: Getter<boolean> = creat
*/
export const deferFlatListFocusChangeRenderUpdate: Getter<boolean> = createJavaScriptFlagGetter('deferFlatListFocusChangeRenderUpdate', false);

/**
* Deprecated in favor of the common flag with the same name, which is the one that can be configured by OSS release stage. This is only kept so JS bundles delivered to older native builds, where the common flag is unavailable, can still enable the feature.
*/
export const enableImperativeEvents_DEPRECATED: Getter<boolean> = createJavaScriptFlagGetter('enableImperativeEvents_DEPRECATED', false);

/**
* When enabled, the React Native renderer dispatches events through the W3C EventTarget API (addEventListener/dispatchEvent) instead of the legacy plugin-based system.
*/
Expand Down
10 changes: 4 additions & 6 deletions packages/react-native/src/private/webapis/dom/nodes/ReactNativeElement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,14 +360,12 @@ ReactNativeElement_public.prototype = ReactNativeElement.prototype;
// `removeEventListener`, `dispatchEvent`) is only inherited by this final class
// when `enableNativeEventTargetEventDispatching` is enabled (which makes
// `ReadOnlyNode` extend `EventTarget`). Until that public API is finalized, it
// is gated behind `enableImperativeEvents` (or its deprecated JS-only
// counterpart, `enableImperativeEvents_DEPRECATED`): when both flags are off we
// remove those methods from this final class. Native/internal event dispatch
// does not rely on these public methods, so removing them is safe.
// is gated behind `enableImperativeEvents`: when off we remove those methods
// from this final class. Native/internal event dispatch does not rely on these
// public methods, so removing them is safe.
if (
ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
!ReactNativeFeatureFlags.enableImperativeEvents() &&
!ReactNativeFeatureFlags.enableImperativeEvents_DEPRECATED()
!ReactNativeFeatureFlags.enableImperativeEvents()
) {
const prototype: interface {
addEventListener?: unknown,
Expand Down
10 changes: 4 additions & 6 deletions packages/react-native/src/private/webapis/dom/nodes/ReadOnlyText.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,12 @@ ReadOnlyText_public.prototype = ReadOnlyText.prototype;
// `removeEventListener`, `dispatchEvent`) is only inherited by this final class
// when `enableNativeEventTargetEventDispatching` is enabled (which makes
// `ReadOnlyNode` extend `EventTarget`). Until that public API is finalized, it
// is gated behind `enableImperativeEvents` (or its deprecated JS-only
// counterpart, `enableImperativeEvents_DEPRECATED`): when both flags are off we
// remove those methods from this final class. Native/internal event dispatch
// does not rely on these public methods, so removing them is safe.
// is gated behind `enableImperativeEvents`: when off we remove those methods
// from this final class. Native/internal event dispatch does not rely on these
// public methods, so removing them is safe.
if (
ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching() &&
!ReactNativeFeatureFlags.enableImperativeEvents() &&
!ReactNativeFeatureFlags.enableImperativeEvents_DEPRECATED()
!ReactNativeFeatureFlags.enableImperativeEvents()
) {
const prototype: interface {
addEventListener?: unknown,
Expand Down
Loading