Repository navigation
chore: fix lints from newer clippy and nightly deprecations - #1622
Merged
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
akern40
added a commit
that referenced
this pull request
Oct 19, 2026
#1575 moved `ndim` off of `Dimension` and onto the new `Ranked` supertrait. Generic code with a `D: Dimension` bound still works, but calling `.ndim()` on a concrete dimension type now needs `Ranked` in scope, so this stopped compiling: ```rust use ndarray::prelude::*; Ix2(3, 4).ndim(); // E0599: trait `Ranked` is not in scope ``` This exports `Ranked` from the prelude next to `Dimension`. Code that imports `ndarray::Dimension` directly, rather than going through the prelude, still has to import `ndarray::layout::ranked::Ranked` too. CI is red until #1622 lands. That PR fixes lints from newer toolchains that also fail on `refactor` itself. Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on
refactoris currently red because of newer toolchains, not code changes. Since CI runs with-D warnings, the following are now errors:clippy::from_iter_instead_of_collect, so ourallowfor it inlib.rsnow errors.question_markfires inIndicesand theIter/IndexedIteriterators.manual_checked_opsfires ininto_scalar.std::f64/std::isizemodules and constants. These are used intests/numeric.rsand in tests indimension/mod.rsandtri.rs.No behavior change.
Link to Devin session: https://app.devin.ai/sessions/4b52e943e29a466ea652d856b7f556c4
Open in Devin Desktop: https://app.devin.ai/desktop/session/4b52e943e29a466ea652d856b7f556c4?variant=devin
Requested by: @akern40